Added: Implementation of POST login and logout #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
requested changes
Aug 14, 2024
There was a problem hiding this comment.
I'm all for changing the logout to be a POST. If you want to update this PR to just be that change we can get it merged.
Let's discuss login flows in #308. I'm sorry for the misunderstanding.
|
Just to confirm, would you like me to switch the logout to use only POST and remove the current GET method, or should I add POST support and keep GET as it is? |
|
I think we need to continue to support logouts with GET until django 4.2 is no longer supported. That matches Django's policy. |
Co-authored-by: Tim Schilling <schilling711@gmail.com>
tim-schilling
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
I'm in favor of this change. I'd like to include the additional docs changes if you're okay with that @simon-spier0 and @JonasKs
Co-authored-by: Tim Schilling <schilling711@gmail.com>
Co-authored-by: Tim Schilling <schilling711@gmail.com>
Co-authored-by: Tim Schilling <schilling711@gmail.com>
Co-authored-by: Tim Schilling <schilling711@gmail.com>
Co-authored-by: Tim Schilling <schilling711@gmail.com>
Co-authored-by: Tim Schilling <schilling711@gmail.com>
JonasKs
approved these changes
Sep 30, 2024
|
Thank you @simon-spier0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added support for POST in login and logout.
#308, #280